Skip to content

Remove duplicated declaration of gp_create_table_random_default_distribution - #2002

Merged
tuhaihe merged 1 commit into
apache:mainfrom
andr-sokolov:duplicated_declaration
Sep 23, 2026
Merged

tuhaihe merged 1 commit into
apache:mainfrom
andr-sokolov:duplicated_declaration

Conversation

@andr-sokolov

Copy link
Copy Markdown
Collaborator

gp_create_table_random_default_distribution is a GUC variable and it is
declared in guc.h. There is no need to declare it a second time in cdbvars.h.

@leborchuk leborchuk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, already declared in

extern bool gp_create_table_random_default_distribution;

…ibution

gp_create_table_random_default_distribution is a GUC variable and it is
declared in guc.h. There is no need to declare it a second time in cdbvars.h.
@yjhjstz
yjhjstz force-pushed the duplicated_declaration branch from 6dcf3b8 to 95d4bff Compare September 22, 2026 02:42
@tuhaihe
tuhaihe merged commit b3f0cea into apache:main Sep 23, 2026
210 of 214 checks passed
@andr-sokolov
andr-sokolov deleted the duplicated_declaration branch September 23, 2026 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants